Github user dmjones500 commented on the issue:

    https://github.com/apache/commons-lang/pull/251
  
    We need to agree on the desired behaviour of the method. Based on the 
signature, I think we can adjust it to support supplementary characters without 
violating the implied contract of the method. The issue for me is about indexes.
    
    Based on the JavaDoc description, I suggest we return the code unit index. 
This is because the input is a `CharSequence` and the JavaDoc states:
    
    > Finds the first index within a `CharSequence`, handling null.
    
    Also, a `CharSequence` only has methods which operate on code unit indexes. 
So returning a code unit index would be helpful for further operations on the 
sequence.
    
    What does everyone else think? We should obviously update the JavaDocs to 
make it crystal clear what we decide, either way.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to