GitHub user mureinik opened a pull request: https://github.com/apache/commons-lang/pull/262
Findbugs in Travis CI This PR adds FindBugs to Travis CI so it can be used to automatically evaluate new patches instead of having to do so retroactively. It contains a series of patches that either fix existing FindBugs errors or excludes them (either because the violation is intentional or because FindBugs cannot properly assess the code) - individual commit messages explain individual decisions. At the end of that series of patches is a patch that adds the `findbugs:check` goal to Travis CI, so it would now be applied on any new PR. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mureinik/commons-lang findbugs Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-lang/pull/262.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #262 ---- commit a96cd5fd9ed9163101591eb83d965b425cbe211b Author: Allon Mureinik <amure...@redhat.com> Date: 2017-04-01T08:44:39Z FindBugs exclude filter for StringUtils Exclude ES_COMPARING_PARAMETER_STRING_WITH_EQ FindBugs warnings from StringUtils methods compare(String, String, boolean) and compareIgnoreCase(String, String, boolean). The usages of the == operator seem to be intentional optimizations similar to the usage in indexOfDifference. If this reasoning is ever overruled, this suppression should be removed. commit b4fa061c2991c3dc9832570b80ef55ce125b533d Author: Allon Mureinik <amure...@redhat.com> Date: 2017-04-01T09:18:53Z Exclude SF_SWITCH_NO_DEFAULT on FastDateParser FastDateParser#simpleQuote uses a switch case that actually has a default branch in it, but doesn't use break statements. SF_SWITCH_NO_DEFAULT unfortunately cannot recognize this pattern, and leave us with no choice but to suppress it. commit 44d3dddcd1c6f3161395489027b6963fa8e0f071 Author: Allon Mureinik <amure...@redhat.com> Date: 2017-04-01T09:38:54Z Exclude SF_SWITCH_FALLTHROUGH on FastDatePrinter FastDatePrinter#appendFullDigits uses a switch statement that intentionally falls through the cases. This patch adds a FindBugs suppression for it. commit 60e087c652f080d7826d1f244f1e6e9adc708e6a Author: Allon Mureinik <amure...@redhat.com> Date: 2017-04-01T09:18:53Z Exclude SF_SWITCH_NO_DEFAULT on FastDatePrinter FastDatePrinter#appendFullDigits uses a switch case without break statements. SF_SWITCH_NO_DEFAULT unfortunately cannot recognize this pattern, and leave us with no choice but to suppress it. commit 3525f756d087e3de370bc069fca96b7ab298b8c3 Author: Allon Mureinik <amure...@redhat.com> Date: 2017-04-01T09:16:52Z Add a default case to switch to appease FindBugs commit ea0b56f409699dbc5e983892d73315ed7139e452 Author: Allon Mureinik <amure...@redhat.com> Date: 2017-04-01T09:49:24Z Add FindBugs to Travis CI This patch copies the FindBugs configuration in pom.xml from the reporting section to the build section so findbugs can be used as part of the build process (by using the maven goal findbugs:check). It then adds this goal to the Travis CI build so that FindBugs becomes part of the CI, and new patches would be prevented from introducing new FindBugs errors. ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---