[
https://issues.apache.org/jira/browse/CONFIGURATION-258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035995#comment-16035995
]
Oliver Heger commented on CONFIGURATION-258:
--------------------------------------------
Finally I came to reviewing this patch (sorry that it took so long). The patch
looks pretty good. Below are some comments:
* The name {{AbstractMapBasedConfiguration}} could be confused with
{{MapConfiguration}} (which is completely unrelated). Could there be a better
name describing what JSON and YAML have in common? (I have trouble with finding
one, too.)
* Is it possible to add the copy constructors supported by other hierarchical
configurations (that accept another hierarchical configuration as argument)?
* Please make sure that all source files have the Apache license header.
Ideally, even test data files should have headers if possible. (Not sure
whether JSON supports comments, I think YAML does.)
* We do not use @author tags any longer, so they should be removed.
* What is the json_helper.js file about?
* Some more comments, especially on newly introduced public methods, would be
good. But I could also add them later.
Thank you very much for your contribution.
> JSON configuration
> ------------------
>
> Key: CONFIGURATION-258
> URL: https://issues.apache.org/jira/browse/CONFIGURATION-258
> Project: Commons Configuration
> Issue Type: New Feature
> Components: Format
> Affects Versions: 1.3
> Reporter: Antonio López-Cerón Vivo
> Priority: Minor
> Fix For: 2.x
>
> Attachments: commons-configuration2-yaml.and.json.support.diff
>
>
> JSON is a lightweight data-interchange format
> {code}
> {"menu": {
> "id": "file",
> "value": "File",
> "popup": {
> "menuitem": [
> {"value": "New", "onclick": "CreateNewDoc()"},
> {"value": "Open", "onclick": "OpenDoc()"},
> {"value": "Close", "onclick": "CloseDoc()"}
> ]
> }
> }}
> {code}
> All references can be located at
> http://www.json.org/
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
