[
https://issues.apache.org/jira/browse/NUMBERS-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16039506#comment-16039506
]
Amey Jadiye commented on NUMBERS-38:
------------------------------------
Hello [~erans],
I have submitted code for your review, now latest test case only going to test
values generated by {{LanczosApproximation.java}} against code given
[Here|https://rosettacode.org/wiki/Gamma_function#Java] which was scope of this
jira and we can merge and close it.
My intent is modifying code with no breaks anywhere, I've reviewed the code in
{{GammaDistribution}} we might need to change it if we go with my approach,
and anyway we are segregating Math and Numbers so we are in that flow to change
it little more.
Lets see what others are thinking, for now we can close this ticket as it have
completed its purpose.
> No unit tests for "LanczosApproximation" class
> ----------------------------------------------
>
> Key: NUMBERS-38
> URL: https://issues.apache.org/jira/browse/NUMBERS-38
> Project: Commons Numbers
> Issue Type: Test
> Reporter: Gilles
> Labels: unit-test
> Fix For: 1.0
>
> Attachments: NUMBERS-38.patch
>
>
> The computation of the {{LanczosApproximation}} (package
> {{o.a.c.numbers.gamma}} in module {{commons-numbers-gamma}}) function is not
> checked by unit tests.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
