[
https://issues.apache.org/jira/browse/CLI-274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16047477#comment-16047477
]
ASF GitHub Bot commented on CLI-274:
------------------------------------
Github user britter commented on a diff in the pull request:
https://github.com/apache/commons-cli/pull/12#discussion_r121589195
--- Diff:
src/test/java/org/apache/commons/cli/PatternOptionBuilderTest.java ---
@@ -159,13 +161,15 @@ public void testURLPattern() throws Exception
@Test
public void testExistingFilePattern() throws Exception
{
- final Options options = PatternOptionBuilder.parsePattern("f<");
+ final Options options = PatternOptionBuilder.parsePattern("f<g<");
--- End diff --
Looking at this, I think we're doing to many things at once in this test.
Why don't we split this test up into to separate tests? One for `f<` and one
for `g<`?
> Option parser type EXISTING_FILE_VALUE not check file existing
> --------------------------------------------------------------
>
> Key: CLI-274
> URL: https://issues.apache.org/jira/browse/CLI-274
> Project: Commons CLI
> Issue Type: Bug
> Components: Parser
> Reporter: Béla Schaum
> Priority: Minor
>
> When the user pass option type FileInputStream.class, I think the expected
> behavior for the return value is the same type, which the user passed.
> Options options = new Options();
> options.addOption(Option.builder("f").hasArg().type(FileInputStream.class).build());
> CommandLine cline = new DefaultParser().parse(options, args);
> FileInputStream file = (FileInputStream) cline.getParsedOptionValue("f"); //
> it returns "File" object, without check File exist.
> I attach a solution for it:
> https://github.com/schaumb/commons-cli/commit/abfcc8211f529ab75f3b3edd4a827e484109eb0b
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
