[ https://issues.apache.org/jira/browse/COMPRESS-416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16072968#comment-16072968 ]
ASF GitHub Bot commented on COMPRESS-416: ----------------------------------------- GitHub user sesuncedu opened a pull request: https://github.com/apache/commons-compress/pull/48 COMPRESS-416 Extended times for Zip should be signed values This has fixed code, and almost fixed tests (fixed for jdk9; haven't removed all the invalid checks for jdk8). You can merge this pull request into a Git repository by running: $ git pull https://github.com/sesuncedu/commons-compress COMPRESS-416 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-compress/pull/48.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #48 ---- commit e39151c1db4784e517fc139c0ee37ab9f035aa0b Author: Simon Spero <sesunc...@gmail.com> Date: 2017-07-03T22:24:55Z COMPRESS-416 Add signed 32bit int constructor and accessor to ZipLong Signed-off-by: Simon Spero <sesunc...@gmail.com> commit da5fa04a69d6c039376f26d0d5896995cecddc65 Author: Simon Spero <sesunc...@gmail.com> Date: 2017-07-03T23:10:10Z COMPRESS-416 Use signed integers for extended timestamps, per spec Signed-off-by: Simon Spero <sesunc...@gmail.com> ---- > Tests failing under jdk 9 : one reflection issue, one change to ZipEntry > related issue > -------------------------------------------------------------------------------------- > > Key: COMPRESS-416 > URL: https://issues.apache.org/jira/browse/COMPRESS-416 > Project: Commons Compress > Issue Type: Bug > Affects Versions: 1.14, 1.15 > Environment: JDK 9 ( jdk9 tree tip - I believe this is what will be > the RC, or if not, what would have been RC). > java.runtime.version = 9-internal+0-adhoc.ses.jdk9 > java.specification.version = 9 > java.version = 9-internal > java.vm.specification.version = 9 > os.arch = amd64 > os.name = Linux > os.version = 4.4.0-81-generic > Reporter: Simon Spero > Fix For: 1.15 > > Attachments: surefire-reports.zip > > > X5455_ExtendedTimestampTest is failing under JDK 9 , due to what appears to > be a bogus value returned from getTime(). It seems like the test failure > might be due to the changes introduced for this: > https://bugs.openjdk.java.net/browse/JDK-8073497 > Tests were run using intelliJ TestRunner, using the openjdk9 build from the > tip of the jdk9 tree (not dev). I believe that this is at most one commit > away from what will be the RC (which was delayed at the last minute due to > two issues, one of which was javadoc related, and the other hotspot. -- This message was sent by Atlassian JIRA (v6.4.14#64029)