[ https://issues.apache.org/jira/browse/TEXT-98?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16099033#comment-16099033 ]
ASF GitHub Bot commented on TEXT-98: ------------------------------------ Github user arunvinudss commented on the issue: https://github.com/apache/commons-text/pull/57 @ameyjadiye I want to remove the isDelimiter method. I would be surprised if someone uses isDelimiter separately because all it does is to check if a given element is present in an array or not. Moreover the isDelimiter char version is already dead code as we don't use it anymore. I would say the scope of the isDelimiter should have been private. > Remove isDelimiter() and use HashSets for delimiter check > --------------------------------------------------------- > > Key: TEXT-98 > URL: https://issues.apache.org/jira/browse/TEXT-98 > Project: Commons Text > Issue Type: Improvement > Affects Versions: 1.1 > Reporter: Arun Vinud > Priority: Minor > Fix For: 1.2 > > > The current implementation of *capitalize*, *uncapitalize* and *initials* in > *WordUtils* calls *isDelimiter* for every character and/or codepoint and > isDelimiter loops through the array of delimiters to check for the > occurrence. This is a bit inefficient and results in O(nk) complexity and it > can be reduced to O( n )[if n>k] or O( k ) [if k>n]. -- This message was sent by Atlassian JIRA (v6.4.14#64029)