[
https://issues.apache.org/jira/browse/BCEL-297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16238969#comment-16238969
]
ASF GitHub Bot commented on BCEL-297:
-------------------------------------
GitHub user zhangminglei opened a pull request:
https://github.com/apache/commons-bcel/pull/20
[BCEL-297] Fix NPE in BCELComparator concrete implementations.
This PR fix the potential NPE.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhangminglei/commons-bcel BCEL-297
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-bcel/pull/20.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #20
----
commit 2338bf801caf437c3ee11cc666d2054c8f56d968
Author: zhangminglei <zml13856086...@163.com>
Date: 2017-11-04T12:43:35Z
[BCEL-297] Fix NPE in BCELComparator concrete implementations.
----
> Incorrect override implementation of Object.equals
> --------------------------------------------------
>
> Key: BCEL-297
> URL: https://issues.apache.org/jira/browse/BCEL-297
> Project: Commons BCEL
> Issue Type: Bug
> Reporter: Mark Roberts
> Priority: Minor
>
> classfile/JavaClass.java:
> classfile/Field.java:
> classfile/Constant.java:
> classfile/Method.java:
> generic/FieldGen.java:
> generic/MethodGen.java:
> all define a bcelComparator that overrides Object.equals. However, they will
> throw a null pointer exception for myConstant.equals(null) instead of
> returning false. This non-standard behavior should either be corrected or
> documented.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
