[ 
https://issues.apache.org/jira/browse/NUMBERS-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16276173#comment-16276173
 ] 

Gilles commented on NUMBERS-50:
-------------------------------

bq. I have changed two lines in pom.xml 
{{<logViolationsToConsole>true</logViolationsToConsole>}}{{<failOnViolation>true</failOnViolation>}}

This should not be done as part of this issue/PR.

bq. we dont really target included in checkstyle checks

No, but it is not necessary to explicitly "suppress" it since running {{mvn 
clean site}} does not report any error.
Please _disable_ {{<failOnViolation>}} and remove the 
"checkstyle-suppressions.xml" file; then run the above command to confirm that 
we obtain the same behaviour.

If another maven command behaves differently, I'd think that odd; but I'd not 
deem it a sufficient reason to add an otherwise non-necessary file.

Anyways, it looks like this report can be resolved since as of today there is 
no checkstyle violations in the module {{commons-numbers-complex}}.

> Clean checkstyle for Complex
> ----------------------------
>
>                 Key: NUMBERS-50
>                 URL: https://issues.apache.org/jira/browse/NUMBERS-50
>             Project: Commons Numbers
>          Issue Type: Bug
>            Reporter: Eric Barnhill
>            Priority: Trivial
>
> Clean up trailing whitespaces and other checkstyle violations in 
> commons-numbers-complex



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to