[
https://issues.apache.org/jira/browse/DBUTILS-136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthew Hall updated DBUTILS-136:
---------------------------------
Labels: easyfix patch usability (was: easyfix usability)
Description:
This visibility restriction on {{CaseInsensitiveHashMap}} is too strict for no
good reason:
{{private static class CaseInsensitiveHashMap extends LinkedHashMap<String,
Object>}}
This should be specified as:
{{protected static class CaseInsensitiveHashMap extends LinkedHashMap<String,
Object>}}
Otherwise it's painful to override or re-implement methods such as {{public
Map<String, Object> toMap(ResultSet rs) throws SQLException}}.
Patch available at
https://github.com/megahall/dbutils/tree/megahall/DBUTILS-136 .
was:
This visibility restriction on {{CaseInsensitiveHashMap}} is too strict for no
good reason:
{{private static class CaseInsensitiveHashMap extends LinkedHashMap<String,
Object>}}
This should be specified as:
{{protected static class CaseInsensitiveHashMap extends LinkedHashMap<String,
Object>}}
Otherwise it's painful to override or re-implement methods such as {{public
Map<String, Object> toMap(ResultSet rs) throws SQLException}}.
> CaseInsensitiveHashMap cannot be accessed by subclasses of BasicRowProcessor
> ----------------------------------------------------------------------------
>
> Key: DBUTILS-136
> URL: https://issues.apache.org/jira/browse/DBUTILS-136
> Project: Commons DbUtils
> Issue Type: Bug
> Affects Versions: 1.7
> Reporter: Matthew Hall
> Labels: easyfix, patch, usability
>
> This visibility restriction on {{CaseInsensitiveHashMap}} is too strict for
> no good reason:
> {{private static class CaseInsensitiveHashMap extends LinkedHashMap<String,
> Object>}}
> This should be specified as:
> {{protected static class CaseInsensitiveHashMap extends LinkedHashMap<String,
> Object>}}
> Otherwise it's painful to override or re-implement methods such as {{public
> Map<String, Object> toMap(ResultSet rs) throws SQLException}}.
> Patch available at
> https://github.com/megahall/dbutils/tree/megahall/DBUTILS-136 .
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
