[
https://issues.apache.org/jira/browse/NUMBERS-48?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16340877#comment-16340877
]
Eric Barnhill commented on NUMBERS-48:
--------------------------------------
I have been pushing my commits to a branch called complex-dev .
Would you prefer:
1) accepting my pull request, then merging into master yourself
2) me merging into master, then submitting pull request
Eric
> Unreachable statements in Complex.abs()
> ---------------------------------------
>
> Key: NUMBERS-48
> URL: https://issues.apache.org/jira/browse/NUMBERS-48
> Project: Commons Numbers
> Issue Type: Bug
> Reporter: David Nickerson
> Priority: Minor
> Labels: easyfix, newbie, patch
> Fix For: 1.0
>
> Attachments: complex_abs.patch
>
>
> This return statement in Complex.abs() is unreachable:
> {code:java}
> if (FastMath.abs(real) < FastMath.abs(imaginary)) {
> if (imaginary == 0.0) {
> return FastMath.abs(real);
> }
> {code}
> If imaginary == 0, then there's no way that the preceding condition would be
> true. There are two similar inner 'if' statements that were accidentally
> switched. Returned values are still correct, but performance suffers.
> The attached patch switches these back. Note that we're still protected from
> dividing by zero.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
