[ 
https://issues.apache.org/jira/browse/MATH-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16342274#comment-16342274
 ] 

Matt Juntunen commented on MATH-1437:
-------------------------------------

Thanks! I am planning on adding some more updates. Here's what I have in mind 
so far (time-willing):
 # Finish adding unit tests for the other packages mentioned in this issue in 
order to flush out any remaining bugs (I know there are at least a couple left) 
and provide a good base for refactoring later on.
 # Create a separate commons-geometry project like you have mentioned earlier.
 # Update/clean up the API to make it easier to use. It's kind of a beast right 
now. One of the biggest things I'd like to change is all of the type casts 
necessary in order to perform any kind of meaningful operation. There are 
general interfaces for all of the types, but in many places the code has to 
assume a particular concrete implementation and cast to it in order to do 
useful work.
 # Look into improving performance, especially for bsp tree creation from 
boundaries. Right now, the code  takes over a minute to create a PolyhedronsSet 
for the utah teapot (~1500 facets). Other libraries I've used could do 
approximately the same thing in a few milliseconds. Admittedly, these other 
libraries don't have the features that commons-math does, but still, a minute 
is way too long here.

I would like to add classes for reading and writing geometry data from other 
file formats but I think the core functionality needs polishing first.

> Add/extend unit tests for o.a.c.m.geometry.partitioning and related packages
> ----------------------------------------------------------------------------
>
>                 Key: MATH-1437
>                 URL: https://issues.apache.org/jira/browse/MATH-1437
>             Project: Commons Math
>          Issue Type: Test
>    Affects Versions: 4.X
>            Reporter: Matt Juntunen
>            Priority: Major
>             Fix For: 4.X
>
>
> Additional unit tests should be added for the following packages:
>  * o.a.c.m.geometry.partitioning
>  * o.a.c.m.geometry.euclidean.oned
>  * o.a.c.m.geometry.euclidean.twod
>  * o.a.c.m.geometry.euclidean.threed
> The current tests provide adequate code coverage but don't seem to thoroughly 
> exercise the code base and check edge cases.
>  
> Pull request: https://github.com/apache/commons-math/pull/77



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to