Github user kinow commented on a diff in the pull request:

    https://github.com/apache/commons-lang/pull/311#discussion_r164283366
  
    --- Diff: src/main/java/org/apache/commons/lang3/time/TimingRecordNode.java 
---
    @@ -0,0 +1,222 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *      http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.commons.lang3.time;
    +
    +import java.util.LinkedList;
    +import java.util.List;
    +import org.apache.commons.lang3.ArrayUtils;
    +import org.apache.commons.lang3.StringUtils;
    +
    +/**
    + * The tree node to track time and children.
    + * The {@code StopWatch} class is used for timings
    + */
    +public class TimingRecordNode {
    +
    +    /**
    +     * The format String for creating paths.
    +     */
    +    private static final String PATH_FMT = "%s/%s";
    +
    +    /**
    +     * This nodes parent's path.
    +     */
    +    private String parentTimingPath;
    +
    +    /**
    +     * The name of this node.
    +     */
    +    private String timingName;
    +
    +    /**
    +     * The tags associated with this timing.
    +     */
    +    private String[] tags;
    +
    +    /**
    +     * The child nodes of this node.
    +     */
    +    private List<TimingRecordNode> children = new LinkedList<>();
    --- End diff --
    
    Would it make much difference if we used an `ArrayList` here? We seem to 
`#add` only in `createChild()`, and not sure if we are using any head/tail 
operation, nor inserting with indexes. So maybe having an `ArrayList` would 
give us the same functionality for less memory?


---

Reply via email to