[
https://issues.apache.org/jira/browse/LANG-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16378622#comment-16378622
]
ASF GitHub Bot commented on LANG-1373:
--------------------------------------
Github user ottobackwards commented on the issue:
https://github.com/apache/commons-lang/pull/311
the static factory, is pretty straight forward.
The try with resources, less so. What ends up happening is you cannot stop
the watch before visiting the nodes.
For example, this is what you want to do if you are going to time, but
visit later:
```java
@Test
public void testTryWithResources() {
final StopWatch stopWatch = new StopWatch();
try(StackWatch<String,String> watch = new
StackWatch<>("testStackWatch")) {
watch.start();
stopWatch.start();
stopWatch.stop();
}
watch.visit(new StackWatch.TimingVisitor<String,String>() {
@Override
public void visitTiming(int level, List<String> path,
StackWatch.Timing<String,String> node) {
assertTrue(node.getStopWatch().getNanoTime() >
stopWatch.getNanoTime());
}
});
}
```
but it won't work/compile with try with resources
> Stopwatch based capability for nested, named, timings in a call stack
> ---------------------------------------------------------------------
>
> Key: LANG-1373
> URL: https://issues.apache.org/jira/browse/LANG-1373
> Project: Commons Lang
> Issue Type: New Feature
> Components: lang.time.*
> Reporter: Otto Fowler
> Assignee: Otto Fowler
> Priority: Major
> Labels: commons-lang,
> Attachments: LANG-1373.patch
>
>
> While working on adding some timing functionality to a Metron feature, I came
> across the
> Stopwatch class, but found that it didn’t suite my needs.
> What I wanted to do was to create a timing from a top level function in our
> Stellar dsl, and have have a group of related timings, such that the end
> result was the overall time of the call, and nested timings of other calls
> executed during the dsl execution of that function. These timings would all
> be named, and have a path for identification and include timing the language
> compiler/execution as well as the function execution itself. It would be
> helpful if they were tagged in some way as well, such that the consumer could
> filter during visitation.
> So I have written StackWatch to provide this functionality, and submitted it
> in a Metron PR.
> From the PR description:
> StackWatch
> A set of utility classes under the new package stellar.common.timing have
> been added. These provide the StackWatch functionality.
> StackWatch provides an abstraction over the Apache Commons StopWatch class
> that allows callers to create multiple named and possibly nested timing
> operations.
> <…>
> This class may be more generally useful to this and other projects, but I am
> not sure where it would live since we wouldn’t want it in common.
> StackWatch uses a combination of Deque and a custom Tree implementation to
> create, start and end timing operations.
> A Visitor pattern is also implemented to allow for retrieving the results
> after the completion of the operation.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
