[ 
https://issues.apache.org/jira/browse/MATH-1459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16463924#comment-16463924
 ] 

Gilles commented on MATH-1459:
------------------------------

Thanks for the changes; the functionality looks more flexible now.

As noted previously, I find it quite confusing that the unit test inherits from 
the {{LevenbergMarquardtOptimizerTest}} class: I would rather expect an 
independent class that "builds" two LS problems, one with the analytical 
Jacobian and the other with the new feature, and performs some comparisons 
(accuracy, performance) between them (the point being for a user to see what is 
implied by his choice of {{MultivariateJacobianFunction}} implementation).
 For this purpose, the optimizer is an "implementation detail" and more 
implementations/optimizers could be added to the test class.
 If for that purpose, you need the "BevingtonProblem" class, do not hesitate to 
extract it from {{LevenbergMarquardtOptimizerTest}} and make it independent (as 
was done for other classes like {{CircleProblem}} etc.).

> Create a way to calculate the Jacobian Matrix using a Differentiator
> --------------------------------------------------------------------
>
>                 Key: MATH-1459
>                 URL: https://issues.apache.org/jira/browse/MATH-1459
>             Project: Commons Math
>          Issue Type: Improvement
>    Affects Versions: 4.X
>            Reporter: adrian
>            Priority: Minor
>             Fix For: 4.X
>
>
> Create a way to automatically calculateĀ a Jacobian Matrix using a 
> Differentiator.
> I have done this with a pull request, but would like feedback.
> edit:  https://github.com/apache/commons-math/pull/84



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to