[ https://issues.apache.org/jira/browse/CODEC-246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16493580#comment-16493580 ]
Gary Gregory edited comment on CODEC-246 at 5/29/18 2:30 PM: ------------------------------------------------------------- I see now, sorry. If we use: {noformat} Index: src/test/java/org/apache/commons/codec/language/ColognePhoneticTest.java =================================================================== --- src/test/java/org/apache/commons/codec/language/ColognePhoneticTest.java (revision 1832403) +++ src/test/java/org/apache/commons/codec/language/ColognePhoneticTest.java (working copy) @@ -19,6 +19,7 @@ import org.apache.commons.codec.EncoderException; import org.apache.commons.codec.StringEncoderAbstractTest; +import org.junit.Assert; import org.junit.Test; /** @@ -142,7 +143,7 @@ {"ganz", "G\u00e4nse"}, // Gänse {"Miyagi", "Miyako"}}; for (final String[] element : data) { - this.getStringEncoder().isEncodeEqual(element[1], element[0]); + Assert.assertTrue(element[1] + " != " + element[0], this.getStringEncoder().isEncodeEqual(element[1], element[0])); } } {noformat} Then the test fails. Feel free to provide a PR. was (Author: garydgregory): I see now, sorry. If we use: {noformat} Index: src/test/java/org/apache/commons/codec/language/ColognePhoneticTest.java =================================================================== --- src/test/java/org/apache/commons/codec/language/ColognePhoneticTest.java (revision 1832403) +++ src/test/java/org/apache/commons/codec/language/ColognePhoneticTest.java (working copy) @@ -19,6 +19,7 @@ import org.apache.commons.codec.EncoderException; import org.apache.commons.codec.StringEncoderAbstractTest; +import org.junit.Assert; import org.junit.Test; /** @@ -142,7 +143,7 @@ {"ganz", "G\u00e4nse"}, // Gänse {"Miyagi", "Miyako"}}; for (final String[] element : data) { - this.getStringEncoder().isEncodeEqual(element[1], element[0]); + Assert.assertTrue(element[1] + " != " + element[0], this.getStringEncoder().isEncodeEqual(element[1], element[0])); } } {noformat} Then the test fails. > ColognePhoneticTest.testIsEncodeEquals missing assertions > --------------------------------------------------------- > > Key: CODEC-246 > URL: https://issues.apache.org/jira/browse/CODEC-246 > Project: Commons Codec > Issue Type: Improvement > Reporter: Oscar Luis Vera Pérez > Priority: Trivial > > The test method ColognePhoneticTest.isEncodeEquals misses an assertion to > properly verify the ColognePhonetic.isEncodeEquals method. -- This message was sent by Atlassian JIRA (v7.6.3#76005)