[
https://issues.apache.org/jira/browse/CODEC-246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16495063#comment-16495063
]
ASF GitHub Bot commented on CODEC-246:
--------------------------------------
GitHub user oscarlvp opened a pull request:
https://github.com/apache/commons-codec/pull/13
[CODEC-246] Fixed the first pair used to test isEncodeEqual
After placing the assertion, the first pair failed. "Meyer" and
"M\u00fcller"
don't have the same code. Replaced "Meyer" by "Mueller".
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/oscarlvp/commons-codec trunk
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-codec/pull/13.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #13
----
commit 4879ed77564a77d6e03f2ef61990c776358a302d
Author: oscarlvp <oscarlvp@...>
Date: 2018-05-30T11:43:10Z
[CODEC-246] Fixed the first pair used to test isEncodeEqual
After placing the assertion, the first pair failed. "Meyer" and
"M\u00fcller"
don't have the same code. Replaced "Meyer" by "Mueller".
----
> ColognePhoneticTest.testIsEncodeEquals missing assertions
> ---------------------------------------------------------
>
> Key: CODEC-246
> URL: https://issues.apache.org/jira/browse/CODEC-246
> Project: Commons Codec
> Issue Type: Improvement
> Reporter: Oscar Luis Vera Pérez
> Priority: Trivial
>
> The test method ColognePhoneticTest.isEncodeEquals misses an assertion to
> properly verify the ColognePhonetic.isEncodeEquals method.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
