[
https://issues.apache.org/jira/browse/VFS-590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16541822#comment-16541822
]
Zoltan Levardy commented on VFS-590:
------------------------------------
thanks Gary. I hoped there is a patch as mentioned, and no development on this
part at least 6 month. I have piece of old code, what was working fine on old
vfs, and no way to get it done with vfs2. There is always a point when needed
to leave things to go. In my case vfs2 drooped, jsch code to replace, less
elegant, but do the job. It is no reason to wait for vfs2 miracle to come.
> SFTP moveTo operation might fail on permission checks even if the operation
> itself might succeed
> ------------------------------------------------------------------------------------------------
>
> Key: VFS-590
> URL: https://issues.apache.org/jira/browse/VFS-590
> Project: Commons VFS
> Issue Type: Bug
> Affects Versions: Nightly Builds
> Reporter: L
> Priority: Major
>
> Continuing with SFTP moveTo, see VFS-588 and VFS-589 for more details.
> The permission checks that VFS performs during moveTo() can result in
> failure.
> org.apache.commons.vfs2.provider.AbstractFileObject.moveTo(final FileObject
> destFile) starts with some checks:
> {code:java}
> @Override
> public void moveTo(final FileObject destFile) throws FileSystemException
> {
> if (canRenameTo(destFile))
> {
> if (!getParent().isWriteable())
> {
> throw new
> FileSystemException("vfs.provider/rename-parent-read-only.error",
> getName(),
> getParent().getName());
> }
> }
> else
> {
> if (!isWriteable())
> {
> throw new
> FileSystemException("vfs.provider/rename-read-only.error", getName());
> }
> }
> {code}
> The problem is: isWriteable() might fail or even hang. Performing moveTo
> without this check might successfully rename the file.
> isWriteable() in case of SFTP can fail if the server disables SSH
> channelExec. Or if it does not support "id" command.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
