[ 
https://issues.apache.org/jira/browse/GEOMETRY-21?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16629680#comment-16629680
 ] 

Matt Juntunen commented on GEOMETRY-21:
---------------------------------------

This is really interesting. So, the tests pass just by changing the threshold 
for the angle calculation method? This method is from the original commons-math 
code so I'm not sure why the threshold was set to what it was.

> Investigate Norm Accuracy
> -------------------------
>
>                 Key: GEOMETRY-21
>                 URL: https://issues.apache.org/jira/browse/GEOMETRY-21
>             Project: Apache Commons Geometry
>          Issue Type: Task
>            Reporter: Matt Juntunen
>            Priority: Minor
>
> Based on discussion in GEOMETRY-17, we should investigate the floating point 
> accuracy of the current Vector normalization methods. Specifically, when the 
> UnitVector private subclass in Vector3D is implemented to return exactly 1.0, 
> the SphericalPolygonsSetTest#testGeographicalMap unit test in 
> commons-geometry-enclosing begins to fail. We should
>  # Determine the cause of this failure.
>  # Determine if the current approach with the UnitVector subclasses 
> introduces any issues with floating point accuracy.
>  # Add unit tests for Vector[123]D to quantify and verify the accuracy of the 
> normalization.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to