[ https://issues.apache.org/jira/browse/NUMBERS-84?focusedWorklogId=175121&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-175121 ]
ASF GitHub Bot logged work on NUMBERS-84: ----------------------------------------- Author: ASF GitHub Bot Created on: 14/Dec/18 01:12 Start Date: 14/Dec/18 01:12 Worklog Time Spent: 10m Work Description: darkma773r opened a new pull request #20: NUMBERS-84: Checks for NaN and Infinite in Quaternion Normalization URL: https://github.com/apache/commons-numbers/pull/20 Adding NaN and infinite checks to Quaternion.normalize() and Quaternion.inverse(). I ended up bumping the JDK version from 6 to 8 in order to use Double.isFinite(). If this causes issues, I can rework it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 175121) Time Spent: 10m Remaining Estimate: 0h > Quaternion Normalization Should Check for NaN and Infinite > ---------------------------------------------------------- > > Key: NUMBERS-84 > URL: https://issues.apache.org/jira/browse/NUMBERS-84 > Project: Commons Numbers > Issue Type: Improvement > Reporter: Matt Juntunen > Priority: Blocker > Time Spent: 10m > Remaining Estimate: 0h > > The {{normalize}} and {{inverse}} methods in {{Quaternion}} should check for > NaN and infinite in addition to zero when determining if a norm is valid. -- This message was sent by Atlassian JIRA (v7.6.3#76005)