[
https://issues.apache.org/jira/browse/GEOMETRY-14?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16722266#comment-16722266
]
Gilles commented on GEOMETRY-14:
--------------------------------
I've removed the redundant accessor methods: If {{QuaternionRotation}}
discloses its underlying implementation, then the {{getQuaternion()}} accessor
is all that's needed.
Similarly, a single factory method (namely: {{of(Quaternion q)}}) would be
sufficient.
What is the purpose of {{toArray()}}?
I think that it would make sense to have {{QuaternionRotation}} be an
implementation of a {{Rotation3D}} interface.
> AffineTransform?D Classes
> -------------------------
>
> Key: GEOMETRY-14
> URL: https://issues.apache.org/jira/browse/GEOMETRY-14
> Project: Apache Commons Geometry
> Issue Type: New Feature
> Reporter: Matt Juntunen
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.0
>
>
> We should create AffineTransform?D classes that implement matrix-based affine
> transforms. They should have simple methods for creating translations,
> rotations, and scaling and calculating the inverse.
>
> -Pull Request #1: [https://github.com/apache/commons-geometry/pull/14]-
> Pull Request #2: [https://github.com/apache/commons-geometry/pull/16]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
