[
https://issues.apache.org/jira/browse/LANG-1410?focusedWorklogId=177708&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-177708
]
ASF GitHub Bot logged work on LANG-1410:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Dec/18 19:00
Start Date: 20/Dec/18 19:00
Worklog Time Spent: 10m
Work Description: eceejcr commented on a change in pull request #392:
LANG-1410: eliminate one unnecessary local int variable and add more tests
URL: https://github.com/apache/commons-lang/pull/392#discussion_r243382598
##########
File path: src/main/java/org/apache/commons/lang3/StringUtils.java
##########
@@ -338,15 +338,17 @@ public static boolean isAllEmpty(final CharSequence...
css) {
* @since 3.0 Changed signature from isBlank(String) to
isBlank(CharSequence)
*/
public static boolean isBlank(final CharSequence cs) {
- int strLen;
Review comment:
idx is fine for me
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 177708)
Time Spent: 2h 20m (was: 2h 10m)
> StringsUtil.isBlank check null first
> ------------------------------------
>
> Key: LANG-1410
> URL: https://issues.apache.org/jira/browse/LANG-1410
> Project: Commons Lang
> Issue Type: Improvement
> Components: lang.*
> Reporter: Yifan Guo
> Priority: Minor
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> StringsUtil.isBlank should check null for cs first instead of declaring int
> strLen first.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
