[
https://issues.apache.org/jira/browse/FILEUPLOAD-296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jochen Wiedmann resolved FILEUPLOAD-296.
----------------------------------------
Resolution: Fixed
Fix Version/s: 1.4.1
Merged into master, thank you!
> Speed Up Parsing
> ----------------
>
> Key: FILEUPLOAD-296
> URL: https://issues.apache.org/jira/browse/FILEUPLOAD-296
> Project: Commons FileUpload
> Issue Type: Bug
> Affects Versions: Nightly Builds, 2.x
> Reporter: David Georg Reichelt
> Assignee: Jochen Wiedmann
> Priority: Minor
> Labels: perfomance, pull-request-available
> Fix For: 1.4.1
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> In 4ed6e923cb2033272fcb993978d69e325990a5aa, FileUploadBase.parseRequest was
> changed: Instead of using a buffer declared there and passing it to
> Streams.copy(InputStream, OutputStream , boolean, byte[]),
> Streams.copy(InputStream, OutputStream , boolean) was used.
> This slows down the parsing by ~ 10%: Since in every iteration of the loop a
> new buffer is created in Streams.copy, additional effort is created. I
> therefore recommend to create a buffer and reuse it.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
