jfallows commented on issue #299: Add module-info for Java 9 URL: https://github.com/apache/commons-lang/pull/299#issuecomment-484170301 @GedMarc thanks for the links, will help however I can. I'm intrigued by the _italics_ of "_seemed_ like a good idea". 😄 Libraries designed with a base version of Java9 can handle `module-info.class` at the root, whereas older libraries designed with base version of `Java8` or lower might invalidate assumptions about class file contents when placing `module-info.class` at root, but that should be largely mitigated by placing `module-info.class` under `META-INF/versions/9` instead for runtime discovery by Java9 and higher. Did you find that there were remaining issues where libraries scanned for all class files inside a JAR, even if they were under `META-INF/versions/9` and still tripped up on `module-info.class` due to their historical assumptions about class file structure? If so, is the proposed solution for those libraries to make them resilient to the presence of `module-info.class` in general, whether at the root or under `META-INF/versions/9`, i.e. treat like a bug and fix them? @jodastephen please share details about those error reports if possible, just in case there are additional relevant pitfalls to navigate 👍
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
