Heinrich Bohne created NUMBERS-99:
-------------------------------------

             Summary: Fraction.add(int) and Fraction.subtract(int) ignore risk 
of integer overflow
                 Key: NUMBERS-99
                 URL: https://issues.apache.org/jira/browse/NUMBERS-99
             Project: Commons Numbers
          Issue Type: Bug
          Components: fraction
            Reporter: Heinrich Bohne


The methods {{add(int)}} and {{subtract(int)}} in the class 
{{org.apache.commons.numbers.fraction.Fraction}} do not take into account the 
risk of an integer overflow. For example, (2​^31^ - 1)/2 + 1 = (2​^31^ + 1)/2, 
so the numerator overflows an {{int}}, but when calculated with 
{{Fraction.add(int)}}, the method still returns normally.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to