aherbert commented on a change in pull request #8: Addition of Log Cauchy
Distribution
URL: https://github.com/apache/commons-statistics/pull/8#discussion_r285559136
##########
File path:
commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/LogCauchyDistribution.java
##########
@@ -111,13 +111,10 @@ public double getVariance() {
return Double.POSITIVE_INFINITY;
}
- /* The distribution is not defined for x less than or qual to zero */
-
/**
* {@inheritDoc}
*
- * The lower bound of the support is zero no matter the parameters.
- * The lower bound is open ended for the Support
+ * The lower bound of the support is always zero no matter the parameters.
*
* @return lower bound of the support (always Double.NEGATIVE_INFINITY)
Review comment:
You also need to change this `(always Double.NEGATIVE_INFINITY)` to `(always
zero)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
