aherbert commented on a change in pull request #44: Post release fixes
URL: https://github.com/apache/commons-csv/pull/44#discussion_r293785511
##########
File path: pom.xml
##########
@@ -153,8 +153,9 @@ CSV files of various types.
<checkstyle.version>3.0.0</checkstyle.version>
<checkstyle.header.file>${basedir}/LICENSE-header.txt</checkstyle.header.file>
- <checkstyle.resourceExcludes>LICENSE.txt,
NOTICE.txt</checkstyle.resourceExcludes>
+ <checkstyle.resourceExcludes>LICENSE.txt, NOTICE.txt,
**/maven-archiver/pom.properties</checkstyle.resourceExcludes>
Review comment:
AFAICS there is no checkstyle configuration in commons-parent, or PMD. I
thought it was just up to projects to configure as appropriate. Using the maven
plugin property `checkstyle.resourceExcludes` is not done on other commons
projects I know. These use a `<configuration>` section and `<resourceExcludes>`
tag. There is more than one way to skin a cat.
Are you suggesting to add profiles like those for other optional plugins
such as jacoco? Each project is of a different age and coding style. So a
standard checkstyle probably would not work as is and a transition period to a
common style would be needed. A common style would certainly make browsing
source from different projects easier. I'd say the discussion on this is
outside the scope of this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
