grimreaper commented on issue #48: [WIP] perform the actual migration to JUnit 5 URL: https://github.com/apache/commons-numbers/pull/48#issuecomment-502343499 > , on my part, am finished with this branch. Do you intend to work any further on it? If not, what to do next? Write to the dev mailing list? Yes. We should send it to the list for review. After that we should squash the changes into a single commit and merge. > I guess the pom.xml will have to be modified to remove any dependency related to JUnit 4, but I'm not sure how, since I didn't understand all of the changes made to it when adding JUnit 5 as a dependency alongside JUnit 4. I'll follow up with that after the merge. > From then on, I migrated the file from scratch, meaning I didn't include any of your later changes (this is exactly the scenario I wanted to avoid by agreeing on which pull request should be merged first before any major changes are performed in this branch that would conflict with the other pull request). Sorry about that. I got carried away and kind of forgot :/
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
