[
https://issues.apache.org/jira/browse/NUMBERS-123?focusedWorklogId=269919&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-269919
]
ASF GitHub Bot logged work on NUMBERS-123:
------------------------------------------
Author: ASF GitHub Bot
Created on: 01/Jul/19 00:02
Start Date: 01/Jul/19 00:02
Worklog Time Spent: 10m
Work Description: Schamschi commented on pull request #60: NUMBERS-123:
Javadoc
URL: https://github.com/apache/commons-numbers/pull/60
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 269919)
Time Spent: 10m
Remaining Estimate: 0h
> "BigFraction(double)" is unnecessary
> ------------------------------------
>
> Key: NUMBERS-123
> URL: https://issues.apache.org/jira/browse/NUMBERS-123
> Project: Commons Numbers
> Issue Type: Improvement
> Components: fraction
> Reporter: Gilles
> Assignee: Gilles
> Priority: Trivial
> Fix For: 1.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Constructor {{BigFraction(double value)}} is only called from the
> {{from(double value)}} method.
> Actually, this constructor is misleading as it is indeed primarily a
> conversion from which appropriate {{numerator}} and {{denominator}} fields
> are computed; those could be set by
> the "direct" constructor {{BigFraction(BigInteger num, BigInteger den)}}.
> Moreover, the private field {{ZERO}} goes through this conversion code
> whereas it could constructed "directly", e.g. using {{of(0)}}. Similarly for
> field {{ONE}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
