garydgregory commented on a change in pull request #33: [DBCP-547] Add a ConnectionFactory interface in BasicDataSource.createConnectionFactory() URL: https://github.com/apache/commons-dbcp/pull/33#discussion_r300068772
########## File path: src/test/java/org/apache/commons/dbcp2/TestOracleDriverConnectionFactory.java ########## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.commons.dbcp2; + +import java.sql.Connection; +import java.sql.Driver; +import java.sql.SQLException; +import java.util.Properties; + +/** + * Simple ConnectionFactory impl class that use BasicDataSource.createConnectionFactory() + */ + +public class TestOracleDriverConnectionFactory implements ConnectionFactory { + private final String connectionString; + private final Driver driver; + private final Properties properties; + + /** + * Constructs a connection factory for a given Driver. + * + * @param driver + * The Driver. + * @param connectString + * The connection string. + * @param properties + * The connection properties. + */ + public TestOracleDriverConnectionFactory(final Driver driver, final String connectString, final Properties properties) { Review comment: Use a non-Oracle themed class name since there is nothing Oracle specific here. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
