[
https://issues.apache.org/jira/browse/BCEL-321?focusedWorklogId=274844&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-274844
]
ASF GitHub Bot logged work on BCEL-321:
---------------------------------------
Author: ASF GitHub Bot
Created on: 10/Jul/19 12:41
Start Date: 10/Jul/19 12:41
Worklog Time Spent: 10m
Work Description: garydgregory commented on pull request #29: [BCEL-321]
AbstractClassPathRepository to share findClass logic for repositories
URL: https://github.com/apache/commons-bcel/pull/29
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 274844)
Time Spent: 20m (was: 10m)
> Subclasses of ClassPathRepository only differ by its underlying cache?
> ----------------------------------------------------------------------
>
> Key: BCEL-321
> URL: https://issues.apache.org/jira/browse/BCEL-321
> Project: Commons BCEL
> Issue Type: Improvement
> Reporter: Tomo Suzuki
> Priority: Minor
> Attachments: classpathrepository_code_duplicate.png
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> (After implementing [BCEL-320|https://issues.apache.org/jira/browse/BCEL-320])
> BCEL has different ClassPathRepository classes with slight modification in
> its underlying cache:
> * ClassPathRepository uses HashMap<String, JavaClass> for JavaClass cache
> * MemorySensitiveClassPathRepository uses HashMap<String,
> SoftReference<JavaClass>
> * New LruCacheClassPathRepository by BCEL-320 will use LinkedHashMap<String,
> JavaClass> for JavaClass cache
> The logic of loadClass, storeClass, and findClass methods are almost same
> (attached screenshot of ClassPathRepository and
> MemorySensitiveClassPathRepository as below). I think they can leverage an
> abstraction over the internal cache so that they will have less duplicate
> code.
> After BCEL-320, I'm thinking to create a PR for the abstraction.
> !classpathrepository_code_duplicate.png!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
