[
https://issues.apache.org/jira/browse/NUMBERS-131?focusedWorklogId=279391&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-279391
]
ASF GitHub Bot logged work on NUMBERS-131:
------------------------------------------
Author: ASF GitHub Bot
Created on: 18/Jul/19 23:06
Start Date: 18/Jul/19 23:06
Worklog Time Spent: 10m
Work Description: coveralls commented on issue #66: [NUMBERS-131]
Re-write implementations of double approximation factory methods in BigFraction
URL: https://github.com/apache/commons-numbers/pull/66#issuecomment-513026214
[](https://coveralls.io/builds/24663156)
Coverage increased (+0.2%) to 94.471% when pulling
**cf54480eb238d9e3f722d9626842c864f7369d03 on Schamschi:NUMBERS-131** into
**3eb540507a559b4c37a802c489b8c9218cf6bc9c on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 279391)
Time Spent: 20m (was: 10m)
> Re-designing BigFraction.from(double, double, int, int)
> -------------------------------------------------------
>
> Key: NUMBERS-131
> URL: https://issues.apache.org/jira/browse/NUMBERS-131
> Project: Commons Numbers
> Issue Type: Improvement
> Components: fraction
> Affects Versions: 1.0
> Reporter: Heinrich Bohne
> Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The method {{BigFraction.from(double, double, int, int)}} can be improved in
> several ways:
> * It only allows a maximum denominator in the {{int}} range, which defies the
> purpose of having a {{BigFraction}} class in addition to the class
> {{Fraction}}. Since {{BigFraction}} is {{BigInteger}} based, it would only be
> natural to allow the maximum denominator to be passed as a {{BigInteger}}.
> * It only calculates the convergents of the simple continued fraction, but
> not its semi-convergents, so it doesn't necessarily produce the closest
> possible approximation within the given bounds.
> * The design is awkward. Making the method's behavior dependent on the values
> of its arguments is confusing, even the documentation acknowledges this.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
