[
https://issues.apache.org/jira/browse/GEOMETRY-59?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16890596#comment-16890596
]
Matt Juntunen commented on GEOMETRY-59:
---------------------------------------
[~bonastos], I took a look at your PR and I feel like your approach is
definitely superior. It's simpler, more intuitive, and has a solid mathematical
basis. However, my implementation has the benefits of being more widely
applicable (since it's a public, static method of Plane), being able to handle
collinear points, and validating that all input points lie on the computed
plane. So, I'm thinking we take my new {{Plane.fromPoints}} overload and
replace the plane orientation algorithm with yours. I think we could make that
work in a single pass through the point collection. Thoughts?
> unexpected output from PolyhedronsSet::checkPoint
> -------------------------------------------------
>
> Key: GEOMETRY-59
> URL: https://issues.apache.org/jira/browse/GEOMETRY-59
> Project: Apache Commons Geometry
> Issue Type: Bug
> Components: Euclidean 3D
> Reporter: Dirk Bonekämper
> Priority: Major
> Labels: pull-request-available
> Attachments: InsideProblemTest.java
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In my project I'm working with 3D Regions modeled as prisms. The base
> polygons are mostly concave. I got wrong results and boiled it down to the
> attached unit test. It creates a prism with a concave base. A point that is
> above the prism gets classified as INSIDE.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
