[
https://issues.apache.org/jira/browse/LANG-1486?focusedWorklogId=307901&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-307901
]
ASF GitHub Bot logged work on LANG-1486:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Sep/19 14:34
Start Date: 06/Sep/19 14:34
Worklog Time Spent: 10m
Work Description: garydgregory commented on issue #452: [LANG-1486]
Generify builder classes Diffable, DiffBuilder, and
URL: https://github.com/apache/commons-lang/pull/452#issuecomment-528879257
>
>
> Well, after thinking about it, I'm not sure how we should deal with custom
comparisons between two objects of different Type, or even add arbitrary
differences to a diff, even if it's not related to one of the fields of the
base object
Yes, that's a concern but what we started with assumes that the type is the
same. Feel free to continue the discussion on the dev mailing list and propose
a PR :-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 307901)
Time Spent: 40m (was: 0.5h)
> Generify builder classes Diffable, DiffBuilder, and DiffResult
> --------------------------------------------------------------
>
> Key: LANG-1486
> URL: https://issues.apache.org/jira/browse/LANG-1486
> Project: Commons Lang
> Issue Type: Improvement
> Components: lang.builder.*
> Reporter: Gary Gregory
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Generify builder classes:
> - org.apache.commons.lang3.builder.Diffable<T>
> - org.apache.commons.lang3.builder.DiffBuilder<T>
> - org.apache.commons.lang3.builder.DiffResult<T>
> After the introduction of [LANG-1485], new APIs typed to `Object` were added.
> This feels like wrong and can be resolved with generics.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
