garydgregory edited a comment on issue #446: LANG-1480 getAbbreviatedName refactored to create appropriate length … URL: https://github.com/apache/commons-lang/pull/446#issuecomment-535747664 > Please merge it instead of nitpicking. That's not the best attitude IMO. If you want to follow JUnit 5 conventions, please provide a patch that is consistent over all classes and methods. Having a mix and public and package private will just be confusing to others who will not know which convention to follow.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services