[
https://issues.apache.org/jira/browse/LANG-1480?focusedWorklogId=319313&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-319313
]
ASF GitHub Bot logged work on LANG-1480:
----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Sep/19 01:48
Start Date: 27/Sep/19 01:48
Worklog Time Spent: 10m
Work Description: garydgregory commented on issue #446: LANG-1480
getAbbreviatedName refactored to create appropriate length …
URL: https://github.com/apache/commons-lang/pull/446#issuecomment-535749533
> > > Please merge it instead of nitpicking.
> > > That's not the best attitude IMO.
>
> I said please. Btw: I opened a ticket
https://issues.apache.org/jira/browse/LANG-1491 to fix this issue.
It's rather simple IMO: this patch should be consistent with the current
code base as it is now. IOW, tests are `public`.
If someone wants to do the busy work of changing all of Commons Lang, more
power to them, then the community can decide what to do, but this PR is not the
place to do it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 319313)
Remaining Estimate: 16h 40m (was: 16h 50m)
Time Spent: 7h 20m (was: 7h 10m)
> ClassUtils. getAbbreviatedName(String ,int) returns too long result
> -------------------------------------------------------------------
>
> Key: LANG-1480
> URL: https://issues.apache.org/jira/browse/LANG-1480
> Project: Commons Lang
> Issue Type: Bug
> Components: lang.*
> Affects Versions: 3.9
> Environment: Environment independent.
> Reporter: Peter Verhas
> Assignee: Bruno P. Kinoshita
> Priority: Major
> Original Estimate: 24h
> Time Spent: 7h 20m
> Remaining Estimate: 16h 40m
>
> In some cases, the algorithm decides incorrectly when to which package names
> to abbreviate. For example, abbreviating
> {{org.apache.commons.lang3.ClassUtils}} to the length 18 will result
> {{o.a.c.lang3.ClassUtils}} (22 characters) instead of {{o.a.c.l.ClassUtils}}
> (18 characters as requested). The reason for this is that the algorithm
> starts from the right and goes to the left abbreviating the packages and
> starts to abbreviate the packages when it runs out of the available space.
> Instead, the algorithm should start from the left and abbreviate all packages
> that would result in a too-long string without abbreviating the package name.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
