[
https://issues.apache.org/jira/browse/IO-628?focusedWorklogId=322025&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-322025
]
ASF GitHub Bot logged work on IO-628:
-------------------------------------
Author: ASF GitHub Bot
Created on: 02/Oct/19 16:30
Start Date: 02/Oct/19 16:30
Worklog Time Spent: 10m
Work Description: garydgregory commented on issue #97: IO-628: Migration
to JUnit Jupiter
URL: https://github.com/apache/commons-io/pull/97#issuecomment-537574369
> > Hi @mureinik,
> > Thank you for your update.
> > It seems like in `TailerTest` there should be a cleaner way to tear down
tests than by calling `Thead.interrupt()`. Can
`org.apache.commons.io.input.Tailer.stop()` be used with or without changes to
`Tailer` to clean up tests in a nicer manner?
> > Gary
>
> @garydgregory The original JUnit 4 test tried doing that in the
`tearDown()` method, which is too late (since it's called after the temp dir
deletion is attempted). Note this isn't new to JUnit Jupiter - it was too late
in JUnit 4 too, but it was pretty harmless there (the deletion silently failed,
and just left some junk on the temp filesystem, whereas in Jupiter it fails the
test).
>
> By using a shared temp directory, we can delay the deletion till after the
end of the entire class, and won't have to try something dirty like explicitly
interrupting the thread, which would be arguably cleaner. I've updated the PR
with this approach..
@mureinik
I still see calls to `thread.interrupt();`; did you forget to remove those?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 322025)
Time Spent: 4h 50m (was: 4h 40m)
> Migration Commons-IO to JUnit Jupiter
> -------------------------------------
>
> Key: IO-628
> URL: https://issues.apache.org/jira/browse/IO-628
> Project: Commons IO
> Issue Type: Task
> Components: Utilities
> Reporter: Allon Mureinik
> Priority: Minor
> Time Spent: 4h 50m
> Remaining Estimate: 0h
>
> Migrate the Commons IO project to the modern JUnit Jupiter framework (instead
> of JUnit 4 which it currently uses) in order to make it easier to maintain
> and for future contributors to participate.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
