garydgregory commented on issue #91: Add drain method to CollectionUtils URL: https://github.com/apache/commons-collections/pull/91#issuecomment-546550659 You should check your tests before committing ;-) as the build fails. WRT API name, `removeRange` is reminiscent of `java.util.Arrays.copyOfRange(...)` so it should be OK: we are removing a range of items specified by input args. But we can do better than `removeByDrain` IMO. "ByDrain" is confusing since 'drain' and 'remove' are synonymous. It feels to me like a `removeCount` is more precise. You could reuse `.CollectionUtils.checkIndexBounds(int)` You should also clean up your formatting as it seems all over the place, looking at it in GitHub at least.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
