[ 
https://issues.apache.org/jira/browse/COLLECTIONS-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16985141#comment-16985141
 ] 

Gilles Sadowski commented on COLLECTIONS-728:
---------------------------------------------

I don't think that it is Commons practice to have documentation files under the 
"src/main" directory.  They go somewhere under "src/site" where they are 
collected to create the web site.

It seems that the [Collections] Checkstyle rules are more lenient than for 
other Commons components...

I'm still not convinced about the "dynamic" {{Factory}}.
I again suggest that the first PR should only contain the core functionality.

The new external dependency is likely to be frowned upon: Issue should be 
raised on the ML.

> BloomFilter contribution
> ------------------------
>
>                 Key: COLLECTIONS-728
>                 URL: https://issues.apache.org/jira/browse/COLLECTIONS-728
>             Project: Commons Collections
>          Issue Type: Task
>            Reporter: Claude Warren
>            Priority: Minor
>         Attachments: BF_Func.md, BloomFilter.java, BloomFilterI2.java, 
> Usage.md
>
>
> Contribution of BloomFilter library comprising base implementation and gated 
> collections.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to