[ https://issues.apache.org/jira/browse/COMPRESS-477?focusedWorklogId=351739&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-351739 ]
ASF GitHub Bot logged work on COMPRESS-477: ------------------------------------------- Author: ASF GitHub Bot Created on: 02/Dec/19 05:14 Start Date: 02/Dec/19 05:14 Worklog Time Spent: 10m Work Description: bodewig commented on pull request #84: COMPRESS-477 Add support for extracting splitted zip files URL: https://github.com/apache/commons-compress/pull/84#discussion_r341815590 ########## File path: src/main/java/org/apache/commons/compress/archivers/zip/ZipArchiveInputStream.java ########## @@ -367,13 +367,9 @@ public ZipArchiveEntry getNextZipEntry() throws IOException { private void readFirstLocalFileHeader(final byte[] lfh) throws IOException { readFully(lfh); final ZipLong sig = new ZipLong(lfh); - if (sig.equals(ZipLong.DD_SIG)) { Review comment: I think I'd prefer to make this conditional on an explicit flag passed in the constructor so people who do not expect split archives won't see incomplete archives without any indication of the problem. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 351739) Time Spent: 5h 10m (was: 5h) > Support for splitted zip files > ------------------------------ > > Key: COMPRESS-477 > URL: https://issues.apache.org/jira/browse/COMPRESS-477 > Project: Commons Compress > Issue Type: New Feature > Components: Archivers > Affects Versions: 1.18 > Reporter: Luís Filipe Nassif > Priority: Major > Labels: zip > Fix For: 1.20 > > Time Spent: 5h 10m > Remaining Estimate: 0h > > It would be very useful to support splitted zip files. I've read > [https://pkware.cachefly.net/webdocs/casestudies/APPNOTE.TXT] and understood > that simply concatenating the segments and removing the split signature > 0x08074b50 from first segment would be sufficient, but it is not that simple > because compress fails with exception below: > {code} > Caused by: java.util.zip.ZipException: archive's ZIP64 end of central > directory locator is corrupt. > at > org.apache.commons.compress.archivers.zip.ZipFile.positionAtCentralDirectory64(ZipFile.java:924) > ~[commons-compress-1.18.jar:1.18] > at > org.apache.commons.compress.archivers.zip.ZipFile.positionAtCentralDirectory(ZipFile.java:901) > ~[commons-compress-1.18.jar:1.18] > at > org.apache.commons.compress.archivers.zip.ZipFile.populateFromCentralDirectory(ZipFile.java:621) > ~[commons-compress-1.18.jar:1.18] > at > org.apache.commons.compress.archivers.zip.ZipFile.<init>(ZipFile.java:295) > ~[commons-compress-1.18.jar:1.18] > at > org.apache.commons.compress.archivers.zip.ZipFile.<init>(ZipFile.java:280) > ~[commons-compress-1.18.jar:1.18] > at > org.apache.commons.compress.archivers.zip.ZipFile.<init>(ZipFile.java:236) > ~[commons-compress-1.18.jar:1.18] > {code} -- This message was sent by Atlassian Jira (v8.3.4#803005)