[
https://issues.apache.org/jira/browse/NUMBERS-136?focusedWorklogId=353771&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-353771
]
ASF GitHub Bot logged work on NUMBERS-136:
------------------------------------------
Author: ASF GitHub Bot
Created on: 04/Dec/19 21:08
Start Date: 04/Dec/19 21:08
Worklog Time Spent: 10m
Work Description: aherbert commented on issue #71: NUMBERS-136: log10()
uses log() functionality
URL: https://github.com/apache/commons-numbers/pull/71#issuecomment-561839176
Hi @ericbarnhill, I think you have based this on an old version of master.
I fixed log10 when fixing the ISO C99 reference test. I changed the
implementation to use Math.log10 in place of Math.log.
Have a look at the current master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 353771)
Time Spent: 20m (was: 10m)
> "log10" inconsistent with "log"
> -------------------------------
>
> Key: NUMBERS-136
> URL: https://issues.apache.org/jira/browse/NUMBERS-136
> Project: Commons Numbers
> Issue Type: Bug
> Components: complex
> Reporter: Gilles Sadowski
> Assignee: Eric Barnhill
> Priority: Major
> Fix For: 1.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> For special cases (containing NaN or infinities), method {{log10}} does not
> return the same values as {{log()}} (cf. case commented out below).
> {code}
> @Test
> public void testLog10Consistency() {
> // Infinities should map to the same values as computed with "log()".
> // Assertions.assertEquals(infInf.log(), infInf.log10());
> Assertions.assertEquals(infNegInf.log(), infNegInf.log10());
> Assertions.assertEquals(negInfInf.log(), negInfInf.log10());
> // Assertions.assertEquals(infNaN.log(), infNaN.log10());
> Assertions.assertEquals(negInfNaN.log(), negInfNaN.log10());
> // Assertions.assertEquals(nanInf.log(), nanInf.log10());
> Assertions.assertEquals(nanNegInf.log(), nanNegInf.log10());
> }
> {code}
> To avoid duplication, I suggest that {{log10}} calls {{log}} as part of its
> implementation.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
