kinow commented on a change in pull request #83: Initial bloom filter code contribution URL: https://github.com/apache/commons-collections/pull/83#discussion_r364541184
########## File path: src/main/java/org/apache/commons/collections4/bloomfilter/hasher/HashFunctionIdentity.java ########## @@ -0,0 +1,161 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.commons.collections4.bloomfilter.hasher; + +import java.nio.charset.StandardCharsets; +import java.util.Comparator; +import java.util.Locale; + +/** + * Defines the a Hash Function used by Hashers. + * + * @since 4.5 + */ +public interface HashFunctionIdentity { + + /** + * A comparator implementation that performs the most common comparison using the + * HashFunctionIdentity name, signedness, and process. + */ + Comparator<HashFunctionIdentity> COMMON_COMPARATOR = new Comparator<HashFunctionIdentity>() { + + @Override + public int compare(HashFunctionIdentity identity1, HashFunctionIdentity identity2) { + int result = identity1.getName().compareToIgnoreCase(identity2.getName()); + if (result == 0) { + result = identity1.getSignedness().compareTo(identity2.getSignedness()); + } + if (result == 0) { + result = identity1.getProcessType().compareTo(identity2.getProcessType()); + } + return result; + } + }; + + /** + * A comparator implementation that performs the most common comparison using the + * HashFunctionIdentity name, signedness, process, and privider.. Review comment: s/privider/provider (maybe single period as well?) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
