kinow commented on a change in pull request #89: Add hashCode method to CollectionUtils URL: https://github.com/apache/commons-collections/pull/89#discussion_r364627077
########## File path: src/main/java/org/apache/commons/collections4/CollectionUtils.java ########## @@ -609,6 +609,33 @@ public static boolean isEqualCollection(final Collection<?> a, final Collection< return isEqualCollection(collect(a, transformer), collect(b, transformer)); } + /** + * Returns the hash code of Collection through the hash method of Equator. + * <p> + * If the input collection is null return 1. Review comment: I think it returns `0`? Maybe something like: "When the collection is {@code null} it returns 0 (zero). The equator must not be {@code null}, otherwise a {@code NullPointerException} is raised." (sorry my rusty Javadoc, I think there's a way to format code/numbers/classes/etc). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services