brettlounsbury commented on a change in pull request #101: IO-649 - Improve the performance of the contentEquals() methods. URL: https://github.com/apache/commons-io/pull/101#discussion_r365991850
########## File path: src/main/java/org/apache/commons/io/IOUtils.java ########## @@ -746,25 +792,74 @@ public static boolean contentEquals(final InputStream input1, final InputStream @SuppressWarnings("resource") public static boolean contentEquals(final Reader input1, final Reader input2) throws IOException { + return contentEquals(input1, input2, DEFAULT_BUFFER_SIZE); + } + + /** + * Compares the contents of two Readers to determine if they are equal or not. + * <p> + * This method buffers the input internally. + * </p> + * + * @param input1 the first reader + * @param input2 the second reader + * @param bufferSize the size of the internal buffer to use. + * @return true if the content of the readers are equal or they both don't + * exist, false otherwise + * @throws NullPointerException if either input is null Review comment: Same answer as above :-) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services