[
https://issues.apache.org/jira/browse/GEOMETRY-80?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17019565#comment-17019565
]
Matt Juntunen commented on GEOMETRY-80:
---------------------------------------
I closed PR #58 so I could squash the commits made during discussion on the ML.
The new PR is https://github.com/apache/commons-geometry/pull/59. This includes
simplification of the {{Transform}} class hierarchy and improved documentation
but does not include any renaming of interfaces, per the ML discussion.
> Rename Transform to AffineTransform
> -----------------------------------
>
> Key: GEOMETRY-80
> URL: https://issues.apache.org/jira/browse/GEOMETRY-80
> Project: Apache Commons Geometry
> Issue Type: Improvement
> Reporter: Matt Juntunen
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The {{Transform}} interface is intended to represent affine transforms only.
> Perhaps, we should then rename this interface to {{AffineTransform}} to
> distinguish it from other transform types (such as projective transforms).
> Pros:
> - Clear, unambiguous name
> - Allows possible use of other transform types later on without naming
> conflicts
> Cons:
> - Name conflicts with {{java.awt.geom.AffineTransform}}
> - I'm not sure if the term "affine" can be used to describe this type of
> transform in spherical space. I've only ever seen it used in discussions
> involving Euclidean space.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
