nnivruth commented on issue #495: LANG-1519 Add zero, positive & negative util methods URL: https://github.com/apache/commons-lang/pull/495#issuecomment-591187253 > What should these method return when a double is not-a-number? @garydgregory, great question. IMO the methods isZero(), isPositive(), isNegative() should return false for float/double NaNs & vice versa for isNotZero(), isNotPositive(), isNotNegative(). I've added these to the test cases as well.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
