aherbert commented on a change in pull request #131: Added caching hasher URL: https://github.com/apache/commons-collections/pull/131#discussion_r387513815
########## File path: src/main/java/org/apache/commons/collections4/bloomfilter/hasher/CachingHasher.java ########## @@ -0,0 +1,233 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.commons.collections4.bloomfilter.hasher; + +import java.nio.charset.StandardCharsets; +import java.util.ArrayList; +import java.util.Arrays; +import java.util.List; +import java.util.NoSuchElementException; +import java.util.PrimitiveIterator; + +import org.apache.commons.collections4.bloomfilter.hasher.HashFunctionIdentity.ProcessType; + +/** + * An implementation of Hasher that attempts to leak as little data as possible. + * Each item in the hasher is represented by two (2) longs. So this Hasher will + * still indicate how many items are in the hasher but will not leak the buffers + * that are being hashed as the @code DynamicHasher} does. + * <p> + * This hasher only accepts HashFunctions that are cyclic in nature. + * </p> + * @see DynamicHasher + * @see ProcessType + */ +public class CachingHasher implements Hasher { + + /** + * The list of byte arrays that are to be hashed. + */ + private final List<long[]> buffers; + + /** + * The hash function identity + */ + private final HashFunctionIdentity functionIdentity; + + /** + * Constructs a CachingHasher from a list of arrays of hash values. + * <p> + * The list of hash values comprises a @code{List<long[]>} where each @code{long[]} Review comment: {@code List<long[]>} and {@code long[]} ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
