[
https://issues.apache.org/jira/browse/CODEC-285?focusedWorklogId=397363&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-397363
]
ASF GitHub Bot logged work on CODEC-285:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Mar/20 08:49
Start Date: 04/Mar/20 08:49
Worklog Time Spent: 10m
Work Description: nhojpatrick commented on pull request #43: CODEC-285
Base32InputStreamTest testReadOutOfBounds
URL: https://github.com/apache/commons-codec/pull/43
Follow up for PR https://github.com/apache/commons-codec/pull/39
From experience people write tests that don't check exceptions correctly,
either they are not thrown, or a different than expected line throws that
exception, or it's the wrong exception, or wrong message.
Using assertAll and assertThrows to explicitly check the expected line
throws the expected exception, and all done in parallel not sequentially.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 397363)
Remaining Estimate: 0h
Time Spent: 10m
> Upgrade to JUnit v5.6.0
> -----------------------
>
> Key: CODEC-285
> URL: https://issues.apache.org/jira/browse/CODEC-285
> Project: Commons Codec
> Issue Type: Improvement
> Reporter: John Patrick
> Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> As Per Email 2020/03/01 11:07, "Java Modules Codec, Collections, IO and
> Lang", and
> https://github.com/apache/commons-collections/blob/master/CONTRIBUTING.md.
> Step 3, update to junit v5.6 (jupiter and vintage)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
