garydgregory commented on a change in pull request #38: [DBCP-562] avoids 
exposing password via JMX
URL: https://github.com/apache/commons-dbcp/pull/38#discussion_r387964778
 
 

 ##########
 File path: src/main/java/org/apache/commons/dbcp2/BasicDataSourceMXBean.java
 ##########
 @@ -201,13 +201,6 @@ default String getDefaultSchema() {
      */
     int getNumIdle();
 
-    /**
 
 Review comment:
   -1: You cannot break binary compatibility, as I mentioned on the mailing 
list already.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to