dota17 commented on issue #138: Update the package-info.java
URL: 
https://github.com/apache/commons-collections/pull/138#issuecomment-599857214
 
 
   Hello,"Alex Herbert" ,
   
commons-collections\src\main\java\org\apache\commons\collections4\bloomfilter\hasher\Shape.java
 Line 253 and 256 maybe  update to 8.
   
   /**
    * Check number of bits is above 8.
    *
    * @param numberOfBits the number of bits
    * @return the number of bits
    * @throws IllegalArgumentException if the number of bits is {@code < 1}
    */
   private static int checkNumberOfBits(final int numberOfBits) {
   if (numberOfBits < 1) {
   throw new IllegalArgumentException("Number of bits must be greater than or 
equal to 8: " + numberOfBits);
   }
   return numberOfBits;
   }
   
   LGFM about package-info.java.
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   在 2020-03-17 00:47:27,"Alex Herbert" <notificati...@github.com> 写道:
   
   I believe the recent changes in master make this PR obsolete. Please check 
the current master and close or rebase the PR with new modifications.
   Thanks.
   
   —
   You are receiving this because you were mentioned.
   Reply to this email directly, view it on GitHub, or unsubscribe.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to